Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade OTel proto version. #1849

Closed
etep opened this issue Mar 1, 2024 · 1 comment
Closed

Upgrade OTel proto version. #1849

etep opened this issue Mar 1, 2024 · 1 comment

Comments

@etep
Copy link

etep commented Mar 1, 2024

Is your feature request related to a problem? Please describe.
Pixie OTel export uses an older version of the Span proto. See, e.g., the following:

  1. Example Pixie source code using older library_spans.

  2. Diff in OTel repository showing deprecation of the same.

IIUC Pixie currently uses OTel proto v0.10.0. The latest OTel proto release is now v1.1.0.

OTel proto v0.19.0 introduced a change where library_spans were completely rm'd, see:
open-telemetry/opentelemetry-proto@v0.18.0...v0.19.0

Describe the solution you'd like
Upgrade Pixie OTel proto to v1.1.0 or to either of v0.18.0 or v0.19.0. Switch to using (e.g.) scope_spans.

Describe alternatives you've considered
As an alternative, we could keep using the older OTel proto version (i.e. do nothing).
@ddelnano ddelnano mentioned this issue Jul 25, 2024
Merged
5 tasks
@ddelnano
Copy link
Member

ddelnano commented Aug 2, 2024

This was completed in #1974.

@ddelnano ddelnano closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@etep @ddelnano