From 8d197e7a49f3d7714aa2ec68ce4fa1aa2bc8e318 Mon Sep 17 00:00:00 2001 From: vikash7485 Date: Tue, 11 Aug 2026 09:23:03 +0530 Subject: [PATCH] fix(web): replace .map() with .forEach() in formalizePoliciesList .map() was used at 4 locations in formalizePoliciesList purely for side effects (.push() into outer arrays). Each .map() call silently creates and discards an intermediate array of undefined values, wasting memory. Using .forEach() is semantically correct. Related: https://github.com/pipe-cd/pipecd/issues/6706 Signed-off-by: vikash7485 --- web/src/utils/formalize-policies-list.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/web/src/utils/formalize-policies-list.ts b/web/src/utils/formalize-policies-list.ts index 50506cf446..9cb450cbb1 100644 --- a/web/src/utils/formalize-policies-list.ts +++ b/web/src/utils/formalize-policies-list.ts @@ -15,13 +15,13 @@ export const formalizePoliciesList = ({ policiesList: ProjectRBACPolicy.AsObject[]; }): string => { const policies: string[] = []; - policiesList.map((policy) => { + policiesList.forEach((policy) => { const resources: string[] = []; - policy.resourcesList.map((resource) => { + policy.resourcesList.forEach((resource) => { let rsc = RBAC_RESOURCE_TYPE_TEXT[resource.type]; if (resource.labelsMap.length > 0) { rsc += "{"; - resource.labelsMap.map((label) => { + resource.labelsMap.forEach((label) => { rsc += label[0] + ":" + label[1] + ","; }); rsc = rsc.slice(0, -1); // remove last comma @@ -31,7 +31,7 @@ export const formalizePoliciesList = ({ }); const actions: string[] = []; - policy.actionsList.map((action) => { + policy.actionsList.forEach((action) => { actions.push(RBAC_ACTION_TYPE_TEXT[action]); });