get PIPECD_VERSION before docker build

Author: linhdangduy

Makefile

@@ -42,8 +42,9 @@ else
 endif
 
 .PHONY: build/web
+build/web: PIPECD_VERSION ?= $(shell git describe --tags --always --abbrev=7 --match 'v[0-9]*.*')
 build/web:
-	yarn --cwd web build
+	PIPECD_VERSION=$(PIPECD_VERSION) yarn --cwd web build
 
 .PHONY: build/chart
 build/chart: VERSION ?= $(shell git describe --tags --always --dirty --abbrev=7 --match 'v[0-9]*.*')
@@ -149,6 +150,7 @@ run/pipecd: $(eval TIMESTAMP = $(shell date +%s))
 # NOTE: previously `git describe --tags` was used to determine the version for running locally
 # However, this does not work on a forked branch, so the decision was made to hardcode at version 0.0.0
 # see: https://github.com/pipe-cd/pipecd/issues/4845
+run/pipecd: PIPECD_VERSION ?= $(shell git describe --tags --always --dirty --abbrev=7 --match 'v[0-9]*.*')
 run/pipecd: BUILD_VERSION ?= "v0.0.0-$(shell git rev-parse --short HEAD)-$(TIMESTAMP)"
 run/pipecd: BUILD_COMMIT ?= $(shell git rev-parse HEAD)
 run/pipecd: BUILD_DATE ?= $(shell date -u '+%Y%m%d-%H%M%S')
@@ -157,7 +159,7 @@ run/pipecd: BUILD_OPTS ?= -ldflags "$(BUILD_LDFLAGS_PREFIX).version=$(BUILD_VERS
 run/pipecd: CONTROL_PLANE_VALUES ?= ./quickstart/control-plane-values.yaml
 run/pipecd:
 	@echo "Building docker image and pushing it to local registry..."
-	docker build -f cmd/pipecd/Dockerfile -t localhost:5001/pipecd:$(BUILD_VERSION) .
+	PIPECD_VERSION=$(PIPECD_VERSION) docker build -f cmd/pipecd/Dockerfile -t localhost:5001/pipecd:$(BUILD_VERSION) .
 	docker push localhost:5001/pipecd:$(BUILD_VERSION)
 
 	@echo "Installing Control Plane in kind..."
@@ -188,8 +190,9 @@ else
 endif
 
 .PHONY: run/web
+run/web: PIPECD_VERSION ?= $(shell git describe --tags --always --abbrev=7 --match 'v[0-9]*.*')
 run/web:
-	yarn --cwd web dev
+	PIPECD_VERSION=$(PIPECD_VERSION) yarn --cwd web dev
 
 .PHONY: run/site
 run/site:

web/package.json

@@ -5,8 +5,8 @@
   "private": true,
   "license": "Apache-2.0",
   "scripts": {
-    "build": "PIPECD_VERSION=`git describe --tags --always --dirty --abbrev=7 --match 'v[0-9]*.*'` webpack build --mode production --env htmlTemplate=./base.html --config ./webpack.config.js",
-    "dev": "PIPECD_VERSION=`git describe --tags --always --dirty --abbrev=7 --match 'v[0-9]*.*'` webpack serve --env htmlTemplate=./base.html --config ./webpack.config.dev.js",
+    "build": "webpack build --mode production --env htmlTemplate=./base.html --config ./webpack.config.js",
+    "dev": "webpack serve --env htmlTemplate=./base.html --config ./webpack.config.dev.js",
     "test": "TZ=Asia/Tokyo jest --config jest.config.local.js",
     "test:coverage": "yarn test --coverage",
     "lint": "eslint --ext .ts,.tsx ./src",