From 9c99d541d5d924b2ea9e2697680924388dad8f90 Mon Sep 17 00:00:00 2001
From: Martin Kluska <martin.kluska@imakers.cz>
Date: Wed, 25 Jan 2017 18:03:36 +0100
Subject: [PATCH] Updated readme + style fixes

---
 README.md                                   | 38 +++++++++++++++++++--
 src/Commands/RecalculatePositionCommand.php |  1 -
 src/PositionObserver.php                    |  2 +-
 3 files changed, 37 insertions(+), 4 deletions(-)

diff --git a/README.md b/README.md
index 39fbc63..ab70f23 100644
--- a/README.md
+++ b/README.md
@@ -8,6 +8,7 @@ and updates the other entries based on the models position value.
 
 * [Installation](#installation)
 * [Usage](#usage)
+    * [Migration example](#migration-example)
     * [Events](#events)
         * [Positioning](#positioning)
         * [Positioned](#positioned)
@@ -30,8 +31,8 @@ composer require pion/laravel-eloquent-position
 1. Add a `position` (can be custom) column in your table (model)
 2. Add `PositionTrait` into your model (if you are using custom column set the `$positionColumn` property)
 3. If you are using grouped entries (like parent_id and etc), you can set the `$positionGroup` with the column name/names (supports single string or multiple columns)
-4. Add to form the position input (can be input[type=number] and etc) and fill/set the position
-5. When position is null or empty string, the last position will be used
+4. Add to form the position input (can be input[type=number] and etc) and fill/set the position on save
+5. When position is null or empty string, the last position will be used.
 
 **Then you can get your entries sorted:**
 
@@ -48,6 +49,39 @@ If using default column name (position), the value will be converted to numeric
 **Get the position**
 Use the `$model->getPosition()` or use the standard way by using the column name `$model->position`
 
+### Migration example
+
+```php
+public function up()
+    {
+    Schema::table('pages', function (Blueprint $table) {
+        $table->smallInteger('position')->default(0)->after('id');
+    });
+
+    // Update the order pages
+    Artisan::call('model:position', [
+        'model'=> \App\Models\Page\Page::class
+    ]);
+}
+```
+
+### Model example
+
+```php
+class Page extends Model
+{
+    use PositionTrait;
+
+    public $table = 'pages';
+    public $positionGroup = ['parent_slug'];
+
+    protected $fillable = [
+        'title', 'slug', 'parent_slug', 'content', 'description', 'position'
+    ];
+    
+}
+```
+
 ### Events
 You can listen to events for positioning changes. You can use the `PositionEventsTrait` for easy model registration.
 
diff --git a/src/Commands/RecalculatePositionCommand.php b/src/Commands/RecalculatePositionCommand.php
index ca8b19f..a63002d 100644
--- a/src/Commands/RecalculatePositionCommand.php
+++ b/src/Commands/RecalculatePositionCommand.php
@@ -1,5 +1,4 @@
 <?php
-
 namespace Pion\Support\Eloquent\Position\Commands;
 
 use Pion\Support\Eloquent\Position\Traits\PositionTrait;
diff --git a/src/PositionObserver.php b/src/PositionObserver.php
index f6a1159..e223290 100644
--- a/src/PositionObserver.php
+++ b/src/PositionObserver.php
@@ -48,7 +48,7 @@ public function saving($model)
             $oldPosition = $model->getOriginal($model->getPositionColumn());
 
             // Check if the position is set
-            if (is_null($position)) {
+            if (is_null($position) || $position == '') {
                 $this->appendLast($model, $oldPosition);
             } else {
                 $this->move($model, $position, $oldPosition);