Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Update timeout-related tests to use TIMEOUT #define #238

Open
levincent06 opened this issue Sep 22, 2021 · 0 comments
Open

[TEST] Update timeout-related tests to use TIMEOUT #define #238

levincent06 opened this issue Sep 22, 2021 · 0 comments
Assignees
@ishan-monie
Labels
code-cleanup Code health fixes/improvements good-first-issue Good issues for incoming members testing Code that demonstrates code behavior

Comments

@levincent06
Copy link
Member

In message.h, we define TIMEOUT to be the maximum number of milliseconds to wait between each message from a device.

We have some tests that connect virtual faulty devices (ForeignTestDevice and UnstableTestDevice). If the test relies on waiting for these devices to timeout, the sleep() duration should be some multiple of TIMEOUT instead of a hardcoded value (ex: 5 seconds)
@levincent06 levincent06 added code-cleanup Code health fixes/improvements testing Code that demonstrates code behavior labels Sep 22, 2021
@benliao1 benliao1 added the good-first-issue Good issues for incoming members label Sep 22, 2021
@zengstellas zengstellas self-assigned this Dec 2, 2021
@wongquijote wongquijote self-assigned this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ishan-monie ishan-monie

Labels
code-cleanup Code health fixes/improvements good-first-issue Good issues for incoming members testing Code that demonstrates code behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zengstellas @benliao1 @levincent06 @wongquijote @ishan-monie