Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift the expected sequence number if a packet was lost #258

Closed
wants to merge 1 commit into from
Closed

Shift the expected sequence number if a packet was lost #258

wants to merge 1 commit into from

Conversation

braams
Copy link

@braams braams commented Jun 17, 2024

Description

Handle the absence of the next packet

Reference issue

Fixes #256

@thatsnotright
Copy link
Contributor

@braams I don't agree with this PR. The intent is that the jitter buffer is agnostic to how packet loss is handled/detected in the case that it can be recovered externally. That means it is up to the caller of the jitter buffer to decide to skip the packet by setting the playback head and not the jitter buffer internals.

@thatsnotright thatsnotright self-assigned this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thatsnotright thatsnotright

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Jitter buffer iterceptor doesn't handle packet loss
2 participants
@braams @thatsnotright