-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break out internal/net/udp #267
Conversation
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
- Coverage 77.82% 77.38% -0.45%
==========================================
Files 76 75 -1
Lines 4077 3944 -133
==========================================
- Hits 3173 3052 -121
+ Misses 623 611 -12
Partials 281 281
Continue to review full report at Codecov.
|
go.mod
Outdated
@@ -3,6 +3,7 @@ module github.com/pion/dtls/v2 | |||
require ( | |||
github.com/pion/logging v0.2.2 | |||
github.com/pion/transport v0.10.0 | |||
github.com/pion/udp v0.0.0-20200620185302-adf622c7c621 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind tagging v0.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind you already made a note :)
Are you able to delete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely agree to split udp package and make it exposed. (pion/transport#57)
Do you think it's better to be a independent package out of pion/transport?
I think we've had overall positive experience with putting 'protocols' in their own repo. While pion/udp is only a thin wrapper it may still be useful on its own. In such case I prefer a separate repo since I want to encourage others to mix and match our protocols into their own stack. The DTLS implementation has been a prime example of this. |
Breaking out the UDP wrapper to make it re- usable in pion/sctp. Relates to pion/sctp#74
Breaking out the UDP wrapper to make it re-
usable in pion/sctp.
Relates to pion/sctp#74
TODO: