fix(web): allow deleting non-empty projects from the warning toast by maria-rcks · Pull Request #1264 · pingdotgg/t3code

maria-rcks · 2026-03-21T01:11:40Z

What Changed

Adds a Delete anyway button to the Project is not empty warning toast.

Clicking it closes the toast, asks for confirmation, then deletes the project's threads and removes the project.

closes #665

Why

Right now the warning blocks project deletion without giving you a way to continue.

This keeps the fix small and makes the warning actionable.

Video

Screen.Recording.2026-03-20.at.9.56.38.PM.mov

Note

Allow force-deleting non-empty projects from the sidebar with a warning toast

Adds a force flag to the ProjectDeleteCommand schema; deleting a non-empty project without it now returns an error.
When a user tries to delete a project with threads, the sidebar shows a warning toast with a 'Delete anyway' destructive action that re-dispatches with force=true.
On force-delete, the server plans thread.deleted events for each active thread before project.deleted, and a new ThreadDeletionReactor background worker stops provider sessions and closes terminals in response.
Toasts gain support for stacked-end action layout and a destructive action variant to render the new warning UI.
On project.deleted, the client's composer draft store clears any draft thread associated with the deleted project and revokes image preview blob URLs.

^{Macroscope summarized 4721345.}

Note

Medium Risk
Touches orchestration deletion semantics and adds a new background reactor that performs best-effort runtime cleanup on thread.deleted, which could impact data consistency and shutdown behavior if incorrect. Changes are scoped and covered by new unit tests, but affect core lifecycle flows for projects/threads.

Overview
Enables force-deleting non-empty projects by extending project.delete with an optional force flag and updating the server decider to either reject non-empty deletes (without force) or plan a sequence of thread.deleted events followed by project.deleted.

Adds a new ThreadDeletionReactor that listens for thread.deleted domain events and performs best-effort cleanup (stop provider sessions, close/delete terminals), and wires it into the server runtime and orchestration reactor startup (with updated tests/harness stubs).

Updates the web sidebar delete flow to show a warning toast with a destructive "Delete anyway" action that re-dispatches project.delete with force=true, adds toast action layout/variant support, and ensures client draft state is cleared on project.deleted while revoking draft image blob URLs.

^{Reviewed by Cursor Bugbot for commit 4721345. Bugbot is set up for automated code reviews on this repo. Configure here.}

coderabbitai · 2026-03-21T01:11:47Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ed56c844-c8ff-4e98-99cb-d216ce4cd1ff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

apps/web/src/components/Sidebar.tsx

macroscopeapp · 2026-04-06T19:38:19Z

Approvability

Verdict: Needs human review

This PR introduces a new feature for force-deleting non-empty projects, including a new ThreadDeletionReactor service, cascade deletion logic, and UI workflow changes. Two unresolved review comments question the architectural approach and event semantics, requiring human review to resolve design concerns.

^{You can customize Macroscope's approvability policy. Learn more.}

juliusmarminge · 2026-04-06T19:53:56Z

apps/web/src/components/Sidebar.tsx

+                for (const threadId of projectThreadIds) {
+                  await deleteThread(threadId, { deletedThreadIds });
+                }
+                await removeProject(projectId);


will this slow down the frontend? should we do it server side with some force: true flag and then do the deletions from there?

apps/web/src/components/Sidebar.tsx

maria-rcks · 2026-04-06T21:01:08Z

@juliusmarminge

juliusmarminge · 2026-04-06T22:03:27Z

apps/server/src/orchestration/decider.ts

+            commandId: command.commandId,
+          }),
+          {
+            type: "thread.deleted" as const,


thread.deleted is emitted when the thread has been deleted. Shouldn't this emit a thread.delete command?

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 526ca72. Configure here.}

apps/web/src/routes/__root.tsx

rookmate · 2026-04-09T13:27:14Z

Would love to get this in the next version. My current work involves going into multiple projects to do multiple one-of tasks in each project and this would help me clean the project tree easily of older projects

apps/web/src/components/Sidebar.tsx

apps/server/src/orchestration/Layers/ThreadDeletionReactor.ts

…ects

github-actions bot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Mar 21, 2026

maria-rcks force-pushed the fix/web-project-delete-anyway branch from f74b447 to b3f029d Compare April 6, 2026 19:17

cursor bot reviewed Apr 6, 2026

View reviewed changes

apps/web/src/components/Sidebar.tsx Outdated Show resolved Hide resolved

juliusmarminge reviewed Apr 6, 2026

View reviewed changes

cursor bot reviewed Apr 6, 2026

View reviewed changes

apps/web/src/components/Sidebar.tsx Show resolved Hide resolved

juliusmarminge reviewed Apr 6, 2026

View reviewed changes

cursor bot reviewed Apr 6, 2026

View reviewed changes

apps/web/src/routes/__root.tsx Outdated Show resolved Hide resolved

maria-rcks force-pushed the fix/web-project-delete-anyway branch from bc591c6 to f171346 Compare April 7, 2026 00:00

maria-rcks force-pushed the fix/web-project-delete-anyway branch from f171346 to 6c3dc9c Compare April 10, 2026 01:53

macroscopeapp bot reviewed Apr 10, 2026

View reviewed changes

apps/web/src/components/Sidebar.tsx Outdated Show resolved Hide resolved

apps/server/src/orchestration/Layers/ThreadDeletionReactor.ts Outdated Show resolved Hide resolved

maria-rcks added 6 commits April 10, 2026 13:09

fix(web): allow deleting non-empty projects from the warning toast

b13dccc

feat(orchestration): force-delete project threads server-side

12b51dd

refactor(orchestration): reuse thread.delete when force-deleting proj…

5f654ed

…ects

fix(web): revoke draft image blob urls on project deletion

20403bd

fix(orchestration): preserve interrupts in thread deletion cleanup

c2986f9

fix(web): keep grouped project delete warning conservative

4721345

maria-rcks force-pushed the fix/web-project-delete-anyway branch from 0aa5be3 to 4721345 Compare April 10, 2026 17:09

github-actions bot added size:XXL 1,000+ changed lines (additions + deletions). size:L 100-499 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). size:XXL 1,000+ changed lines (additions + deletions). labels Apr 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(web): allow deleting non-empty projects from the warning toast#1264

fix(web): allow deleting non-empty projects from the warning toast#1264
maria-rcks wants to merge 6 commits intopingdotgg:mainfrom
maria-rcks:fix/web-project-delete-anyway

maria-rcks commented Mar 21, 2026 •

edited by cursor bot

Loading

Uh oh!

coderabbitai bot commented Mar 21, 2026 •

edited

Loading

Review skipped

Uh oh!

Uh oh!

macroscopeapp bot commented Apr 6, 2026 •

edited

Loading

Uh oh!

juliusmarminge Apr 6, 2026

Uh oh!

Uh oh!

maria-rcks commented Apr 6, 2026

Uh oh!

juliusmarminge Apr 6, 2026

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

rookmate commented Apr 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

maria-rcks commented Mar 21, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Why

Video

Allow force-deleting non-empty projects from the sidebar with a warning toast

Uh oh!

coderabbitai bot commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

macroscopeapp bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

juliusmarminge Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maria-rcks commented Apr 6, 2026

Uh oh!

juliusmarminge Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rookmate commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maria-rcks commented Mar 21, 2026 •

edited by cursor bot

Loading

coderabbitai bot commented Mar 21, 2026 •

edited

Loading

macroscopeapp bot commented Apr 6, 2026 •

edited

Loading

rookmate commented Apr 9, 2026 •

edited

Loading