From 3239c6b899c54d3c3ac75a36f2334c9fd58ad057 Mon Sep 17 00:00:00 2001 From: jiangjianyuan Date: Fri, 14 Jun 2024 11:00:22 +0800 Subject: [PATCH] do not report unretryable error when initializing s3 storage --- pkg/redo/config.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/redo/config.go b/pkg/redo/config.go index 3bcb2d78000..8865e9f4f61 100644 --- a/pkg/redo/config.go +++ b/pkg/redo/config.go @@ -202,12 +202,12 @@ func initExternalStorageForTest(ctx context.Context, uri url.URL) (storage.Exter if ConsistentStorage(uri.Scheme) == consistentStorageS3 && len(uri.Host) == 0 { // TODO: this branch is compatible with previous s3 logic and will be removed // in the future. - return nil, errors.WrapChangefeedUnretryableErr(errors.ErrStorageInitialize, + return nil, errors.WrapError(errors.ErrStorageInitialize, errors.Errorf("please specify the bucket for %+v", uri)) } s, err := util.GetExternalStorageFromURI(ctx, uri.String()) if err != nil { - return nil, errors.WrapChangefeedUnretryableErr(errors.ErrStorageInitialize, err) + return nil, errors.WrapError(errors.ErrStorageInitialize, err) } return s, nil }