Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncpoint(ticdc): set write source before creating SyncTable #11377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

syncpoint(ticdc): set write source before creating SyncTable #11377

wants to merge 1 commit into from
+55 −27

Conversation

CharlesCheung96
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #11375

What is changed and how it works?

TiDB in the BDR secondary role forbids all ddl writes. Therefore, SyncTable cannot be created when syncpoint is enabled on the changefeed from the primary to the secondary. This problem can be solved by setting the writesource before executing the create ddl.

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 2, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from charlescheung96, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Jul 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.6148%. Comparing base (2db0922) to head (32bab52).

Additional details and impacted files
Components Coverage Δ
cdc 61.4030% <0.0000%> (-0.0594%) ⬇️
dm 51.1970% <ø> (-0.0061%) ⬇️
engine 63.4161% <ø> (+0.0635%) ⬆️
Flag Coverage Δ
unit 57.6148% <0.0000%> (-0.0246%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11377        +/-   ##
================================================
- Coverage   57.6393%   57.6148%   -0.0246%     
================================================
  Files           849        849                
  Lines        126162     126162                
================================================
- Hits          72719      72688        -31     
- Misses        48042      48073        +31     
  Partials       5401       5401

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 2, 2024

@CharlesCheung96: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-mysql-test 32bab52 link true /test cdc-integration-mysql-test
pull-cdc-integration-kafka-test 32bab52 link true /test cdc-integration-kafka-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@asddongmen
Copy link
Contributor

Please adjust the bdr-mode integration test case to set the role for TiDB clusters before creating the changefeed. This ensures these changes are covered by the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongyunyan hongyunyan Awaiting requested review from hongyunyan

@asddongmen asddongmen Awaiting requested review from asddongmen

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The creation time of the tidb_cdc.syncpoint_v1 table of the secondary cluster does not meet expectations
2 participants
@CharlesCheung96 @asddongmen