Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

struct tag of PulsarConfig does not comply with APIv2 standards #11334

Open
CharlesCheung96 opened this issue Jun 21, 2024 · 0 comments
Open

Comments

@CharlesCheung96
Copy link
Contributor

struct tag of PulsarConfig does not comply with APIv2 standards where the tag name should be delimited by an underscore rather than a dash.

tiflow/cdc/api/v2/model.go

Lines 1193 to 1213 in 58636ed

type PulsarConfig struct {
TLSKeyFilePath *string `json:"tls-certificate-path,omitempty"`
TLSCertificateFile *string `json:"tls-private-key-path,omitempty"`
TLSTrustCertsFilePath *string `json:"tls-trust-certs-file-path,omitempty"`
PulsarProducerCacheSize *int32 `json:"pulsar-producer-cache-size,omitempty"`
PulsarVersion *string `json:"pulsar-version,omitempty"`
CompressionType *string `json:"compression-type,omitempty"`
AuthenticationToken *string `json:"authentication-token,omitempty"`
ConnectionTimeout *int `json:"connection-timeout,omitempty"`
OperationTimeout *int `json:"operation-timeout,omitempty"`
BatchingMaxMessages *uint `json:"batching-max-messages,omitempty"`
BatchingMaxPublishDelay *int `json:"batching-max-publish-delay,omitempty"`
SendTimeout *int `json:"send-timeout,omitempty"`
TokenFromFile *string `json:"token-from-file,omitempty"`
BasicUserName *string `json:"basic-user-name,omitempty"`
BasicPassword *string `json:"basic-password,omitempty"`
AuthTLSCertificatePath *string `json:"auth-tls-certificate-path,omitempty"`
AuthTLSPrivateKeyPath *string `json:"auth-tls-private-key-path,omitempty"`
OAuth2 *PulsarOAuth2 `json:"oauth2,omitempty"`
OutputRawChangeEvent *bool `json:"output-raw-change-event,omitempty"`
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant