Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dxf: optimize querying eligible tasks in task executor manager #59345

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

dxf: optimize querying eligible tasks in task executor manager #59345

wants to merge 4 commits into from
+52 −20

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Feb 8, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #59344

Problem Summary:

What changed and how does it work?

see issue

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

before vs after
Note:: for the after, out of the remaining 1.9% CPU, only 0.5 is taken by DXF, others are taken by bindinfo/metric collect/cpu observer/runaway watcher, etc, see the third graph
58e0283f-e78e-4e7e-95ec-d022a584495f
278256a7-aa34-4e74-b848-14c7d07d75c1
how DXF query frequency affects CPU usage
image

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2025
@tiprow tiprow
Copy link

tiprow bot commented Feb 8, 2025

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Feb 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.4970%. Comparing base (ad2c9f4) to head (dc8dfcc).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #59345        +/-   ##
================================================
+ Coverage   73.0649%   73.4970%   +0.4321%     
================================================
  Files          1690       1690                
  Lines        467071     467654       +583     
================================================
+ Hits         341265     343712      +2447     
+ Misses       104848     102952      -1896     
- Partials      20958      20990        +32
Flag Coverage Δ
integration 42.9265% <30.4347%> (?)
unit 72.2471% <93.4782%> (-0.0176%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.5116% <ø> (+0.0229%) ⬆️

@D3Hunter D3Hunter changed the title [wip]dxf: optimize querying eligible tasks in task executor manager dxf: optimize querying eligible tasks in task executor manager Feb 10, 2025
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 10, 2025
Benjamin2037
Benjamin2037 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 10, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-10 02:54:41.113108159 +0000 UTC m=+238723.509330221: ☑️ agreed by tangenta.
  • 2025-02-10 06:22:57.946666631 +0000 UTC m=+251220.342888692: ☑️ agreed by Benjamin2037.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reduce the overhead of DXF task executor manager on idle state
3 participants
@D3Hunter @Benjamin2037 @tangenta