Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

var: enable pd_enable_follower_handle_region as default #58385

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

var: enable pd_enable_follower_handle_region as default #58385

wants to merge 4 commits into from
+114 −9

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Dec 18, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58384

Problem Summary:

What changed and how does it work?

as title

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Enable `pd_enable_follower_handle_region` as default

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from okjiang and additionally assign yudongusa for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 26, 2024
@okJiang
Copy link
Member Author

okJiang commented Dec 26, 2024

/retest

@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5250%. Comparing base (8e1a47d) to head (44c7b51).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58385        +/-   ##
================================================
+ Coverage   73.5154%   73.5250%   +0.0095%     
================================================
  Files          1681       1681                
  Lines        464479     464639       +160     
================================================
+ Hits         341464     341626       +162     
+ Misses       102179     102172         -7     
- Partials      20836      20841         +5
Flag Coverage Δ
unit 72.2866% <ø> (+0.0221%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7834% <ø> (-0.0030%) ⬇️

@okJiang
Copy link
Member Author

okJiang commented Dec 27, 2024

/cc @rleungx @JmPotato

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx December 27, 2024 08:13
@okJiang
Copy link
Member Author

okJiang commented Dec 27, 2024

/retest

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 27, 2024

@okJiang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 44c7b51 link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato Awaiting requested review from JmPotato

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set pd_enable_follower_handle_region as default
1 participant
@okJiang