Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tipb and kvproto to use unified protobuf code #57338

Open
overvenus opened this issue Nov 13, 2024 · 0 comments · May be fixed by #57424
Open

Update tipb and kvproto to use unified protobuf code #57338

overvenus opened this issue Nov 13, 2024 · 0 comments · May be fixed by #57424
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@overvenus
Copy link
Member

Enhancement

Recently, tipb and kvproto have unified their protobuf generation options, and reduced bloated code by removing unused fields.

To update them, TiDB need to clean these paddings 1

tidb/pkg/kv/key.go

Lines 102 to 104 in 5129bb3

XXXNoUnkeyedLiteral struct{}
XXXunrecognized []byte
XXXsizecache int32

CC pingcap/kvproto#1278
CC pingcap/tipb#347

Footnotes

  1. https://github.com/pingcap/kvproto/pull/1275#pullrequestreview-2431765868 ↩
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: update tipb kvproto and remove unused fields overvenus/tidb
1 participant
@overvenus