Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Docker build conflates build ARGs with ENV variables #8

Open
2 tasks done
zackproser opened this issue Oct 30, 2023 · 0 comments
Open
2 tasks done

[Bug] Docker build conflates build ARGs with ENV variables #8

zackproser opened this issue Oct 30, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@zackproser
Copy link
Collaborator

Is this a new bug?

  • I believe this is a new bug
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

While we probably DO need to pass in:

  • PINECONE_API_KEY
  • PINECONE_ENVIRONMENT
  • PINECONE_INDEX

During the first build stage - because otherwise the call to new Pinecone will blow up, we do not need to set all the Postgres environment variables via build args.

Instead, we want the container to be as agnostic as possible, and to read everything it needs from the environment. This approach is compatible with ECS Fargate and the Pulumi TypeScript provider we're using to ultimately deploy these containers.

Expected Behavior

See above

Steps To Reproduce

Read

Relevant log output

No response

Environment

- **OS**:
- **Language version**:
- **Pinecone client version**:

Additional Context

No response

@zackproser zackproser added the bug Something isn't working label Oct 30, 2023
@zackproser zackproser self-assigned this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant