Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Cohere embedding models #61

Open
jamescalam opened this issue Dec 7, 2023 · 0 comments
Open

Handle Cohere embedding models #61

jamescalam opened this issue Dec 7, 2023 · 0 comments

Comments

@jamescalam
Copy link
Contributor

          From testing it a bit seems like they know how to ignore this param if v2.0 is provided. I fine with simply mirroring their behavior, but leave it for your choice if to keep this assertion/remove it/add v2.0 to the list. Any choice would be fine IMO

Originally posted by @acatav in #58 (comment)


Creating an issue to implement more flexible approach to handling the Cohere embedding models (likely just remove validation on pinecone-text side).

@jamescalam jamescalam changed the title From testing it a bit seems like they know how to ignore this param if v2.0 is provided. I fine with simply mirroring their behavior, but leave it for your choice if to keep this assertion/remove it/add v2.0 to the list. Any choice would be fine IMO Handle Cohere embedding models Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant