Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Missing Error Handling of all API requests #102

Open
qhenkart opened this issue Feb 8, 2025 · 0 comments
Open

[Bug] Missing Error Handling of all API requests #102

qhenkart opened this issue Feb 8, 2025 · 0 comments
Labels
bug Something isn't working status:needs-triage An issue that needs to be triaged by the Pinecone team

Comments

@qhenkart
Copy link

qhenkart commented Feb 8, 2025

Is this a new bug?
In other words: Is this an error, flaw, failure or fault? Please search Github issues and check our Community Forum to see if someone has already reported the bug you encountered.

If this is a request for help or troubleshooting code in your own Pinecone project, please join the Pinecone Community Forum.

  • [X ] I believe this is a new bug
  • [X ] I have searched the existing Github issues and Community Forum, and I could not find an existing post for this bug

Describe the bug
I don't think this was ever working. The API provides clear documentation on how errors are handled by the API, but the SDK does not format errors. Despite having the code for it

Looking through the internals, all of the IndexConnection API abstractions return an unformatted error returned directly
https://github.com/pinecone-io/go-pinecone/blob/main/pinecone/index_connection.go
that directly return the generated internals instead of parsing it through the shared PineconeError struct

Only the Index API calls return a properly formatted error and randomly two of the Index_connection calls.

Steps to reproduce the issue locally
make a call that resolves to an error in any of the SDK index_connection methods. Note that there is no error formatting or error handling. Leaving the consumer to resolve to string matching

Environment

  • OS Version: N/A
  • Go version: N/A
  • Go SDK version: Latest
@qhenkart qhenkart added the bug Something isn't working label Feb 8, 2025
@github-actions github-actions bot added the status:needs-triage An issue that needs to be triaged by the Pinecone team label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:needs-triage An issue that needs to be triaged by the Pinecone team
Projects
None yet
Development

No branches or pull requests

1 participant