Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage in core/isEqual.js #97

Open
pineapplemachine opened this issue Jul 20, 2017 · 0 comments
Open

Improve test coverage in core/isEqual.js #97

pineapplemachine opened this issue Jul 20, 2017 · 0 comments
Labels
effort: moderate The issue will probably take a single contributor one or two days of work to resolve. meta: good first issue The issue is especially suitable for first-time contributors. type: stability The issue pertains to automated testing or other tools for verifying code correctness.

Comments

@pineapplemachine
Copy link
Owner

pineapplemachine commented Jul 20, 2017 •
edited
Loading

The functions in this module do already have some tests, but they are not adequately exhaustive for such a complicated and commonly needed function. Additional test cases, especially for isEqual, and especially for odd inputs that I wouldn't have anticipated when I wrote the implementation, would be very valuable.

Ideally this task won't uncover any undesirable behavior but, if it does, please let me know so we can discuss the best way to fix it.

(Desirable behavior is defined as the function not failing with errors, and always returning the least astonishing answer.)
@pineapplemachine pineapplemachine added effort: moderate The issue will probably take a single contributor one or two days of work to resolve. type: stability The issue pertains to automated testing or other tools for verifying code correctness. labels Jul 20, 2017
pineapplemachine added a commit that referenced this issue Jul 30, 2017
@pineapplemachine
Additional isEqual test case
09f85d6 
Related to #97

Added to check the source of some unexpected behavior which turned out to be a mistake in the test I wrote rather than here
pineapplemachine added a commit that referenced this issue Aug 7, 2017
@pineapplemachine
Make isEqual(NaN, NaN) return true
b26a161 
Also added an unrelated test case to isEqual per #97
@pineapplemachine pineapplemachine added the meta: good first issue The issue is especially suitable for first-time contributors. label Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: moderate The issue will probably take a single contributor one or two days of work to resolve. meta: good first issue The issue is especially suitable for first-time contributors. type: stability The issue pertains to automated testing or other tools for verifying code correctness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpsullivan @pineapplemachine