Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for addSequenceConverter #164

Open
pineapplemachine opened this issue Nov 8, 2017 · 0 comments
Open

Add tests for addSequenceConverter #164

pineapplemachine opened this issue Nov 8, 2017 · 0 comments
Labels
effort: low The issue will probably take a single contributor no more than one day of work to resolve. meta: good first issue The issue is especially suitable for first-time contributors. priority: medium The issue makes it more difficult for people to use the software. type: stability The issue pertains to automated testing or other tools for verifying code correctness.

Comments

@pineapplemachine
Copy link
Owner

pineapplemachine commented Nov 8, 2017 •
edited
Loading

Prompted by #163 which significantly increases the complexity of what was previously a very simple function. It is important that tests exist to guarantee this function's behavior, especially for more complex inputs than what the core package already expects the function to behave correctly for.
@pineapplemachine pineapplemachine added effort: low The issue will probably take a single contributor no more than one day of work to resolve. meta: good first issue The issue is especially suitable for first-time contributors. priority: medium The issue makes it more difficult for people to use the software. type: stability The issue pertains to automated testing or other tools for verifying code correctness. labels Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low The issue will probably take a single contributor no more than one day of work to resolve. meta: good first issue The issue is especially suitable for first-time contributors. priority: medium The issue makes it more difficult for people to use the software. type: stability The issue pertains to automated testing or other tools for verifying code correctness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pineapplemachine