Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow referral in query string of URL #29

Open
kevinmickey opened this issue Jun 23, 2016 · 5 comments
Open

Allow referral in query string of URL #29

kevinmickey opened this issue Jun 23, 2016 · 5 comments

Comments

@kevinmickey
Copy link

It would be nice to use the referral in the query string of a URL. In order to have backward compatibility, this could be optional. This would have several benefits.

  • Could attach to any URL, so no need to set a redirect_to. Users can decide which url to send, and just add their referral parameter.
  • Might improve SEO, because links are pointing to same destination, just with different query parameters. (Although the crawler can probably handle the redirects)
  • Improves transparency, because a user can see where they are going to be redirected to.
  • Most importantly, reduces link rot. If you remove the pinax referral app, you still have a bunch of referral links out in the wild. Ideally, the links would work but just have an extra ref parameter. Instead, currently they would likely fail or require a patch.

In order to implement, check out: https://github.com/byteweaver/django-referral/blob/master/referral/middleware.py I think the important pinax-referrals code would be moved from a view to middleware.

@ossanna16
Copy link
Contributor

Thanks so much for your suggestion @kevinmickey! Any thoughts about this @paltman and @jtauber?

@surinderdeveloper
Copy link

surinderdeveloper commented Jul 30, 2020

Is there any update for this enhancement? I am using this lib from last one year and now I need this feature. @ossanna16, @kevinmickey

@KatherineMichel
Copy link
Member

@surinderdeveloper This issue was opened quite a while before I began maintaining Pinax, but I'm not aware of an update.

@surinderdeveloper
Copy link

Thanks @KatherineMichel for replying. I saw the documentation and It is not yet updated. Could you please suggest to me how can achieve it? I am already using it but now there is requirement to add referral in the query string of a URL

@KatherineMichel
Copy link
Member

@surinderdeveloper I think @kevinmickey might have a better idea atm of how to do that, since he suggested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants