Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong isLocked flag when folder is locked #823

Open
Corepex opened this issue Feb 21, 2025 · 2 comments
Open

Wrong isLocked flag when folder is locked #823

Corepex opened this issue Feb 21, 2025 · 2 comments
Assignees

Comments

@Corepex
Copy link
Contributor

Corepex commented Feb 21, 2025

I noticed that the API returns the wrong isLocked state in the /api/assets/tree endpoint.

Steps to reproduce

@mattamon
Copy link
Contributor

mattamon commented Feb 24, 2025

I checked the problem and as it seems, the locking mechanismn, does not trigger the GDI

Is there a specific reason to use PATCH instead of the PUT endpoint?

@lukmzig
Copy link
Contributor

lukmzig commented Feb 24, 2025

As you can see for example for data objects here:
https://github.com/pimcore/pimcore/blob/12.x/models/DataObject/AbstractObject/Dao.php#L427

We will need to re-think the approach. When we set propagate on an item, the children elements are always looking for the parent, so no value is set on them. This will not work with the current GDI implementation.

Unlock propagate will probably have a similar issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants