Bug fixed in ShellProperty

Author: pierresprim

CHANGELOG.md

@@ -117,6 +117,10 @@ COMNative 3.0
 - Removals:
     - Some 'ref' keywords in native PortableDevices interfaces. These keywords have been removed for interface type parameters because they was redundant.
 
+## 07/2022 2.12.0.2
+
+Bug fixed in ShellProperty: an exception was thrown (truncation error), even if no truncation were made.
+
 ## 07/2022 2.12
 
 - New constants.

source/WindowsAPICodePack/2.x/Shell.2.x/Shell.2.x.csproj

@@ -7,9 +7,9 @@
 		<Copyright>Copyright © Microsoft 2010, Copyright © Pierre Sprimont 2022</Copyright>
 		<Description>WindowsAPICodePack for Shell</Description>
 		<DefineConstants>WAPICP2;$(DefineConstants)</DefineConstants>
-		<VersionPrefix>2.12.0.1</VersionPrefix>
-		<AssemblyVersion>2.12.0.1</AssemblyVersion>
-		<FileVersion>2.12.0.1</FileVersion>
+		<VersionPrefix>2.12.0.2</VersionPrefix>
+		<AssemblyVersion>2.12.0.2</AssemblyVersion>
+		<FileVersion>2.12.0.2</FileVersion>
 		<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
 		<UseWindowsForms>true</UseWindowsForms>
 		<UseWPF>true</UseWPF>

source/WindowsAPICodePack/3.x/Shell/Shell.csproj

@@ -7,10 +7,10 @@
 		<Copyright>Copyright © Microsoft 2010, Copyright © Pierre Sprimont 2022</Copyright>
 		<Description>WindowsAPICodePack for Shell</Description>
 		<DefineConstants>WAPICP3;$(DefineConstants)</DefineConstants>
-		<VersionPrefix>3.11</VersionPrefix>
+		<VersionPrefix>3.11.0.1</VersionPrefix>
 		<VersionSuffix>preview</VersionSuffix>
-		<AssemblyVersion>3.11</AssemblyVersion>
-		<FileVersion>3.11</FileVersion>
+		<AssemblyVersion>3.11.0.1</AssemblyVersion>
+		<FileVersion>3.11.0.1</FileVersion>
 		<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
 		<UseWindowsForms>true</UseWindowsForms>
 		<UseWPF>true</UseWPF>

source/WindowsAPICodePack/Shared/Shell.Shared/Common/Shell/ShellLink.cs

@@ -114,7 +114,7 @@ public string Comments
 
             set
             {
-                if (value == null? throw new ArgumentNullException(nameof(value)) : NativeShellItem2 != null)
+                if (value == null ? throw new ArgumentNullException(nameof(value)) : NativeShellItem2 != null)
                 {
                     Properties.System.Comment.Value = value;
 
@@ -125,10 +125,7 @@ public string Comments
         #endregion Public Properties
 
         #region Constructors
-        internal ShellLink(in IShellItem2 shellItem) : base(shellItem)
-        {
-            // Left empty.
-        }
+        internal ShellLink(in IShellItem2 shellItem) : base(shellItem) { /* Left empty. */ }
 
 #if WAPICP3
         private ShellLink(in IShellItem2 shellItem, in string sourcePath) : base(shellItem) => TargetLocation = sourcePath;

source/WindowsAPICodePack/Shared/Shell.Shared/PropertySystem/ShellProperty.cs

@@ -100,7 +100,7 @@ private void StorePropVariantValue(PropVariant propVar)
 #endif
                     (hr));
 
-                _ = AllowSetTruncatedValue && result == HResult.InPlaceStringTruncated ? CoreErrorHelper.Succeeded(result) ? writablePropStore.Commit() : throw new PropertySystemException(LocalizedMessages.ShellPropertySetValue, Marshal.GetExceptionForHR((int)result)) : throw new ArgumentOutOfRangeException(nameof(propVar), LocalizedMessages.ShellPropertyValueTruncated);
+                _ = result != HResult.InPlaceStringTruncated || AllowSetTruncatedValue ? CoreErrorHelper.Succeeded(result) ? writablePropStore.Commit() : throw new PropertySystemException(LocalizedMessages.ShellPropertySetValue, Marshal.GetExceptionForHR((int)result)) : throw new ArgumentOutOfRangeException(nameof(propVar), LocalizedMessages.ShellPropertyValueTruncated);
             }
 
             catch (InvalidComObjectException e)