Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct possibility to use a scaling factor (kappa) or not #1

Open
3 tasks
pierrePalud opened this issue Dec 6, 2024 · 0 comments
Open
3 tasks

Correct possibility to use a scaling factor (kappa) or not #1

pierrePalud opened this issue Dec 6, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@pierrePalud
Copy link
Owner

pierrePalud commented Dec 6, 2024

The package was implemented to let the possibility to the user to infer a map of scaling factors $(\kappa_n)$. For each pixel $n$, this scaling factor $\kappa_n$ scales all predicted observables $\ell$ identically, such that the forward model is $\kappa_n f_\ell(\theta_n)$.

Some parts of the current implementation force the user to use a scaling factor. For instance, the current implementations of the MyScaler and NeuralNetworkApprox classes are only valid with a scaling factor. In particular, they enforce D = D_no_kappa + 1 where D is supposed to be the total number of physical parameters, and D_no_kappa the number of physical parameters excluding the scaling factor.

Changes propositions:

  • Change name from kappa to scaling_factor throughout the code for clarity, as this $\kappa$ notation is not widespread.
  • Correct MyScaler class to allow one not to use a scaling factor.
  • Correct NeuralNetworkApprox class to allow one not to use a scaling factor.
@pierrePalud pierrePalud added the bug Something isn't working label Dec 6, 2024
@pierrePalud pierrePalud self-assigned this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant