Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decomposition #29

Open
lichtkind opened this issue Jan 28, 2016 · 11 comments
Open

decomposition #29

lichtkind opened this issue Jan 28, 2016 · 11 comments
Labels
current main devs are working onit, part of very next release

Comments

@lichtkind
Copy link
Collaborator

Not only because panda doesnt work here i want to make a branch without AttrX::lazy and maybe the travis issue also resolve here , but before i want to finalize at least the decomposition section. i wan tto add QR (householder and givens) but due LU I reinvestigated crout and the only difference between jordan and crout LU is reall that crout seems to output (Lu dot D) aka L and Ru and the normal case is Lu and (D dot Ru) aka R. u stands here for unipotent. So there is potention for unification und to have one LU method since crout is only a differnt way to compute and write it doent doesnt change result.

next plan is also new-vandermonde and then finally somehing to iterate eigenvalues.

@lichtkind
Copy link
Collaborator Author

i asked my prof, the algorithm you implemented is wrong he says. we should doublecheck but if so, your mehtod would have to go :) since all the other cases are covered by what i wrote

@pierre-vigier
Copy link
Owner

I copied it from wikipedia
https://en.wikipedia.org/wiki/Crout_matrix_decomposition

On Fri, Jan 29, 2016 at 5:38 PM Herbert Breunung [email protected]
wrote:

i asked my prof, the algorithm you implemented is wrong he says. we should
doublecheck but if so, your mehtod would have to go :) since all the other
cases are covered by what i wrote


Reply to this email directly or view it on GitHub
#29 (comment)
.

@pierre-vigier
Copy link
Owner

Also, could we know where it is wrong? Or at least have one case where it does not work?

May i know why a version without AttrX::Lazy? By the way, Panda is workign again

@lichtkind
Copy link
Collaborator Author

panda never worked here, and today was exam but I will go Tuesday in library and check the details

@lichtkind
Copy link
Collaborator Author

well all i said is written there too: https://en.wikipedia.org/wiki/Crout_matrix_decomposition sounds like my prof is wrong i will write him too again.

@lichtkind
Copy link
Collaborator Author

i will check it in the library and then write here

@lichtkind
Copy link
Collaborator Author

i was now in library and will again because the 4 books i checked doesn't mention crout. so I wound why having him in the name if the result is the same anyway. I think it is better to let the user specify what he wants and to introduce an option if he wants his U matrix unipotent but L not.

btw unipotent would be candidate for another tester method.

@lichtkind
Copy link
Collaborator Author

i just let it open to remind me to check the workings of all decompositions

@lichtkind lichtkind added next main dev to do after current, part of next but one release current main devs are working onit, part of very next release and removed next main dev to do after current, part of next but one release current main devs are working onit, part of very next release labels Mar 26, 2018
@lichtkind lichtkind added next main dev to do after current, part of next but one release and removed current main devs are working onit, part of very next release labels Apr 8, 2018
@lichtkind
Copy link
Collaborator Author

singular value decomposition will be important too

@lichtkind lichtkind added current main devs are working onit, part of very next release and removed next main dev to do after current, part of next but one release labels Sep 22, 2018
@lichtkind
Copy link
Collaborator Author

cholesky is proven to be right

@lichtkind
Copy link
Collaborator Author

SVD: singular value decompost and QR are missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current main devs are working onit, part of very next release
Projects
None yet
Development

No branches or pull requests

2 participants