Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAKEFLAG -j is overwritten in build.sh #2358

Open
L0ric0 opened this issue Mar 8, 2025 · 1 comment
Open

MAKEFLAG -j is overwritten in build.sh #2358

L0ric0 opened this issue Mar 8, 2025 · 1 comment

Comments

@L0ric0
Copy link

L0ric0 commented Mar 8, 2025

Versions

  • Pi-hole: 6.0.4
  • AdminLTE:
  • FTL:

Platform

  • OS and version: Arch
  • Platform: Raspberry Pi 3

Expected behavior

MAKEFLAGS (especially -j) are not overwritten in the build.sh. Setting default values if the flags are not supplied would be perfect but they should not take precedence over ones beeing set on the system.

Actual behavior / bug

Currently in the build.sh script (line 161 cmake --build . -- -j "$(nproc)") overwrites the -j option to the number of processors on the system. While this is fine for most systems on memory constrained ones this makes it impossible to build. (1Gb on RPi3)

Steps to reproduce

Steps to reproduce the behavior:

  1. Set MAKEFLAGS Env var with -j 1
  2. run build.sh
  3. see that the build uses more than one processor

Additional context

Add any other context about the problem here.

@DL6ER
Copy link
Member

DL6ER commented Mar 8, 2025

Please check if branch tweak/buildsh behaves like you'd expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants