From 34b372290c3585e53378b10243ea99802feee5a7 Mon Sep 17 00:00:00 2001 From: Mark Brannan <117125054+markatgrindr@users.noreply.github.com> Date: Thu, 3 Nov 2022 16:12:45 -0700 Subject: [PATCH] Issue 157: No module named 'onelogin.api.client (#158) * Quick fix for issue 157: avoids breaking changes from onelogin python SDK version 3.0.0 by requiring version >= 2.0 but < 3.0 * Fix test assertions to compare integers instead of numeric strings --- onelogin_aws_cli/tests/test_MFACredentials.py | 8 ++++---- requirements.txt | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/onelogin_aws_cli/tests/test_MFACredentials.py b/onelogin_aws_cli/tests/test_MFACredentials.py index ce5eb2fe..2503aff5 100644 --- a/onelogin_aws_cli/tests/test_MFACredentials.py +++ b/onelogin_aws_cli/tests/test_MFACredentials.py @@ -70,21 +70,21 @@ def test_select_device(self): ] self.mfa.select_device(devices[:1]) - self.assertEqual(self.mfa.device.id, '1') + self.assertEqual(self.mfa.device.id, 1) with patch('builtins.input', side_effect=['3']): self.mfa.select_device(devices) - self.assertEqual(self.mfa.device.id, '3') + self.assertEqual(self.mfa.device.id, 3) self.mfa._config["otp_device"] = "DeviceType2" # Ignores invalid selection self.mfa.select_device(devices[:1]) - self.assertEqual(self.mfa.device.id, '1') + self.assertEqual(self.mfa.device.id, 1) self.mfa.select_device(devices) - self.assertEqual(self.mfa.device.id, '2') + self.assertEqual(self.mfa.device.id, 2) del self.mfa._config["otp_device"] diff --git a/requirements.txt b/requirements.txt index beb7a69c..6b480779 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,4 +1,4 @@ boto3 -onelogin +onelogin >= 2.0, < 3.0 keyring requests