Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for synonymies when resolving specifiers against the Open Tree Taxonomy #14

Open
gaurav opened this issue Sep 16, 2019 · 1 comment

Comments

@gaurav
Copy link
Member

gaurav commented Sep 16, 2019

We currently use only the scientific name to tie specifiers to nodes on the phylogeny.

Steps to reproduce:

  1. Create a clade definition that "includes Chelonia mydas and Chelus fimbriata".
  2. Resolve these specifiers on the Open Tree Taxonomy:
  • Chelonia mydas resolves to ott 559133 as Chelonia mydas.
  • Chelus fimbriata resolves to ott 235773 as Chelus fimbriatus.
  1. Reason over this clade definition. This definition does not resolve as expected, likely because the definition in JSON-LD points to Chelus fimbriata, not Chelus fimbriatus.

Possible fixes:

  1. A deeper fix in the Curation Tool would fix this as well (Add support for recording cited relationships between taxonomic units klados#129). In this case, we know that C. fimbriatus in this case is a synonym of C. fimbriata, so we could add this as an annotation.
  2. Instead of using the scientific name, we could use the Open Tree Taxonomy ID as an external identifier for both the specifier and the node. This would guarantee that every OTR definition resolves correctly without any side-effects because of synonymy.
@hlapp
Copy link
Member

hlapp commented Sep 17, 2019

  • In this case, we know that C. fimbriatus is a synonym of C. fimbriata, so we could add this as an annotation.

So doesn't that mean that the resolution to ott 235773 is correct? It sounded like it should have matched something else given better annotation.

  • Instead of using the scientific name, we could use the Open Tree Taxonomy ID as an external identifier for both the specifier and the node. This would guarantee that every OTR definition resolves correctly without any side-effects because of synonymy.

Yes, but are OTT IDs persistent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants