From eef1ac21ef91f0577445355651bd62ae60af8655 Mon Sep 17 00:00:00 2001 From: Matt Friedman Date: Sat, 13 May 2023 20:35:00 -0700 Subject: [PATCH] Improve test coverage Signed-off-by: Matt Friedman --- tests/controller/admin_input_test.php | 1 + tests/controller/ucp_controller_test.php | 15 +++++++++++++++ 2 files changed, 16 insertions(+) diff --git a/tests/controller/admin_input_test.php b/tests/controller/admin_input_test.php index cfaf716..39f53d3 100644 --- a/tests/controller/admin_input_test.php +++ b/tests/controller/admin_input_test.php @@ -115,6 +115,7 @@ public function get_form_data_data() array(true, ['Ad Name #1', 'Ad Note #1', 'Ad Code #1', 0, '', '', 'blah', 5, 0, 0, 0, '', [], false], 0, ['AD_END_DATE_INVALID']), array(true, ['Ad Name #1', 'Ad Note #1', 'Ad Code #1', 0, '', '1970-01-01', '', 5, 0, 0, 0, '', [], false], 0, ['AD_START_DATE_INVALID']), array(true, ['Ad Name #1', 'Ad Note #1', 'Ad Code #1', 0, '', '', '1970-01-01', 5, 0, 0, 0, '', [], false], 0, ['AD_END_DATE_INVALID']), + array(true, ['Ad Name #1', 'Ad Note #1', 'Ad Code #1', 0, '', '2060-01-01', '2050-01-01', 5, 0, 0, 0, '', [], false], 0, ['END_DATE_TOO_SOON']), array(true, ['Ad Name #1', 'Ad Note #1', 'Ad Code #1', 0, '', '', '', 0, 0, 0, 0, '', [], false], 0, ['AD_PRIORITY_INVALID']), array(true, ['Ad Name #1', 'Ad Note #1', 'Ad Code #1', 0, '', '', '', 11, 0, 0, 0, '', [], false], 0, ['AD_PRIORITY_INVALID']), array(true, ['Ad Name #1', 'Ad Note #1', 'Ad Code #1', 0, '', '', '', 5, 0, -1, 0, '', [], false], 0, ['AD_VIEWS_LIMIT_INVALID']), diff --git a/tests/controller/ucp_controller_test.php b/tests/controller/ucp_controller_test.php index 47bcdc1..b59810a 100644 --- a/tests/controller/ucp_controller_test.php +++ b/tests/controller/ucp_controller_test.php @@ -143,6 +143,17 @@ public function main_data() 'ad_views_limit' => 0, 'ad_clicks_limit' => 0, ), + array( + 'ad_id' => 4, + 'ad_name' => 'Fourth ad', + 'ad_views' => 0, + 'ad_clicks' => 0, + 'ad_enabled' => 1, + 'ad_start_date' => 0, + 'ad_end_date' => 1, + 'ad_views_limit' => 0, + 'ad_clicks_limit' => 0, + ), )), array(1, 0, array()), array(0, 1, array()), @@ -165,6 +176,10 @@ public function test_main($enable_views, $enable_clicks, $ads) ->method('get_ads_by_owner') ->willReturn($ads); + $this->helper->expects(self::exactly(count($ads))) + ->method('is_expired') + ->willReturnOnConsecutiveCalls(false, false, false, true); + $this->template->expects(self::exactly(count($ads))) ->method('assign_block_vars');