Resolve path after checking it leads to an existing file

greg0ire · greg0ire · commit b7c704104064 · 2024-01-21T22:13:45.000+01:00
Running the tool without creating a guides.xml is a valid scenario, and
should be supported. This means realpath() may return false, which is not
a valid input for is_file().

Fixes #824
diff --git a/bin/guides b/bin/guides
@@ -40,8 +40,9 @@ if ($input->hasParameterOption('-vvv', true)) {
 
 $containerFactory = new ContainerFactory([new ApplicationExtension()]);
 
-$projectConfig = realpath($vendorDir . '/../guides.xml');
+$projectConfig = $vendorDir . '/../guides.xml';
 if (is_file($projectConfig)) {
+    $projectConfig = realpath($vendorDir . '/../guides.xml');
     if ($verbosity === 3) {
         echo 'Loading guides.xml from ' . $projectConfig . PHP_EOL;
     }

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,9 @@ if ($input->hasParameterOption('-vvv', true)) {`
`40`	`40`
`41`	`41`	`$containerFactory = new ContainerFactory([new ApplicationExtension()]);`
`42`	`42`
`43`		`-$projectConfig = realpath($vendorDir . '/../guides.xml');`
	`43`	`+$projectConfig = $vendorDir . '/../guides.xml';`
`44`	`44`	`if (is_file($projectConfig)) {`
	`45`	`+ $projectConfig = realpath($vendorDir . '/../guides.xml');`
`45`	`46`	`if ($verbosity === 3) {`
`46`	`47`	`echo 'Loading guides.xml from ' . $projectConfig . PHP_EOL;`
`47`	`48`	`}`