Merge pull request #240 from asgrim/fix-phar-overwrite-bug

Fix bug when PHAR is overwritten and EventDispatcher is used

Author: asgrim

src/Command/SelfUpdateCommand.php

@@ -148,6 +148,20 @@ public function execute(InputInterface $input, OutputInterface $output): int
 
         $output->writeln('<info>✅ PIE has been upgraded to ' . $latestRelease->tag . '</info>');
 
-        return Command::SUCCESS;
+        $this->exitSuccessfully();
+    }
+
+    /**
+     * Exit is needed at the moment, as we have an EventDispatcher set on
+     * the application, which means classes try to get loaded (such as
+     * {@see \Symfony\Component\Console\Event\ConsoleTerminateEvent}), but
+     * AFTER we've over-written the PHAR. This results in weird behaviour when
+     * the class tries to get loaded, as the PHAR content changed. Not an
+     * ideal approach, need to look into better ways of handling it, maybe
+     * adding an event listener to overwrite the PHAR *after* the command runs.
+     */
+    private function exitSuccessfully(): never
+    {
+        exit(0);
     }
 }