use smart_str_append() if we have a zend_string*#21414
Merged
Girgias merged 1 commit intophp:masterfrom Mar 21, 2026
Merged
Conversation
TimWolla
reviewed
Mar 11, 2026
| case IS_OBJECT: { | ||
| zend_string *class_name = Z_OBJ_HANDLER_P(arg, get_class_name)(Z_OBJ_P(arg)); | ||
| smart_str_appends(str, "Object("); | ||
| /* cut off on NULL byte ... class@anonymous */ |
Member
There was a problem hiding this comment.
Suggested change
| /* cut off on NULL byte ... class@anonymous */ | |
| /* cut off on NUL byte ... class@anonymous */ |
Prefer NUL when referring to the (char *)0.
Member
Author
There was a problem hiding this comment.
This is copied from an existing comment and people always seem to disagree between NULL and NUL byte... So I'll leave it like this and someone can either try to codify or fix this across the whole codebase.
Girgias
requested review from
DanielEScherzer,
alexdowad,
bukka,
devnexen,
dstogov,
ndossche and
youkidearitai
as code owners
DanielEScherzer
approved these changes
Mar 16, 2026
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
Okay for ext/reflection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.