Handle BSD checksum and file utilities #14690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BSDs have different checksum utilities than GNU systems do. If we don't see the GNU checksum utilities installed, use the BSD ones, as their output is compatible enough. Addresses part of phpGH-14688.
ericmann
approved these changes
Jun 27, 2024
BSD touch at least in macOS does not handle local timezone in the timestamp (like 2024-06-27T10:26:23-03:00). As such, try GNU touch (as ports systems almost always prefix with g if coreutils is installed) and prefer that if available. It's not the end of the world though if GNU touch isn't available, as BSD touch on some systems may support it, and if it doesn't, then it's just timestamps, nothing too serious.
NattyNarwhal
changed the title
|
The alternative way to solve |
|
Would like another review here, as I'm likely going to be using this PR with the alpha2 release so I can do ti on my host system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BSDs have different checksum utilities than GNU systems do. If we don't see the GNU checksum utilities installed, use the BSD ones, as their output is compatible enough.
Also prefers GNU touch if installed, since it supports non-UTC timestamps.
Fixes GH-14688.