Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate expected improvement in BcMath's performance #14675

Open
FleetingCloud opened this issue Jun 26, 2024 · 3 comments
Open

Indicate expected improvement in BcMath's performance #14675

FleetingCloud opened this issue Jun 26, 2024 · 3 comments

Comments

@FleetingCloud
Copy link

FleetingCloud commented Jun 26, 2024

Description

Hi, first of all, thanks a lot for all the work done on BcMath especially Saki Takamachi, nielsdos and Gina.
Currently NEWS file only include following about it:

Improve performance. (Saki Takamachi, nielsdos)

I think it should also tell by how much . It's because a person will likely think that improvement is modest if they just read above news entry. In reality, there is a great performance boost.
By including some benchmark, it will encourage people heavily using BcMath to update their PHP version sooner.
It will also help improve perception of "BCMath is slow" which it is not now.
Also spread more awareness.
Again thank a lot.

Cc @SakiTakamachi

@Girgias
Copy link
Member

Girgias commented Jun 27, 2024

This seems more like a documentation issue for the PHP 8.4 migration guide.

The same could also be said for the DOM extension, and others.

@SakiTakamachi
Copy link
Member

Ah, sorry. There are so many refactorings, I was thinking of providing more detailed information after everything is finished, if necessary.

As you mentioned there could probably be a bit more detail, so I'll update this once the refactoring is settled.

@FleetingCloud
Copy link
Author

No problem.
Take your time. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants