Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation bug for security groups #345

Open
palaueb opened this issue Feb 4, 2022 · 1 comment
Open

Documentation bug for security groups #345

palaueb opened this issue Feb 4, 2022 · 1 comment

Comments

@palaueb
Copy link

palaueb commented Feb 4, 2022

On the link https://php-opencloudopenstack.readthedocs.io/en/latest/services/compute/v2/servers.html#security-groups

the documentation says that we set the security groups by this way:

$options['securityGroups'] = ['secGroup1', 'default', 'secGroup2'];

But it returns error, it may be this way:

$options['securityGroups'] = [
   ['name'=>'secGroup1'],
   ['name'=>'default'],
   ['name'=>'secGroup2']
];

Can we change it? thanks!!

@k0ka
Copy link
Member

k0ka commented Dec 12, 2023

Hello.

  1. our latest documentation is on https://php-openstack-sdk.readthedocs.io/en/latest/services/compute/v2/servers.html#security-groups
  2. It looks like you're right (according to https://docs.openstack.org/api-ref/compute/), but we have to create corresponding test. We also have security_groups defined as array of uuids in https://github.com/php-opencloud/openstack/blob/master/src/Networking/v2/Params.php#L275 which is most probably wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants