Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix retry plugin for async requests #112

Open
dbu opened this issue Oct 9, 2018 · 0 comments
Open

fix retry plugin for async requests #112

dbu opened this issue Oct 9, 2018 · 0 comments

Comments

@dbu
Copy link
Contributor

dbu commented Oct 9, 2018 •
edited
Loading

Q A
Bug? yes
New Feature? no
Version 1.8

Actual Behavior

RetryPlugin used in an async request waits for the response, making the request effectively synchronous.

Expected Behavior

The request stays asynchronous and the RetryPlugin returns an appropriate promise.

Possible Solutions

An attempt was made in #101 but had to be reverted in #111 because of #109.
There is a WIP in #110 but somebody needs to pick that up and revert #111, then test everything in #110 until it works correctly.
@dbu dbu mentioned this issue Oct 9, 2018
Closed
mxr576 added a commit to mxr576/apigee-client-php that referenced this issue Oct 26, 2018
@mxr576
Bump minimum version of php-http/client-common to >=1.8.1.
c41d5da 
1.8.0 contains a regression bug:
php-http/client-common#112
mxr576 added a commit to mxr576/apigee-client-php that referenced this issue Nov 5, 2018
@mxr576
Bump minimum version of php-http/client-common to >=1.8.1.
c63cb90 
1.8.0 contains a regression bug:
php-http/client-common#112
mxr576 added a commit to apigee/apigee-client-php that referenced this issue Nov 6, 2018
@mxr576
Refactored Management API tests and various improvements (#25)
42b3063 
Highlights:

* Block installation of the latest vimeo/psalm.

vimeo/psalm#1016

* Introducing new API and HTTP clients for testing.

* Updated Management API tests to use the new test API- and HTTP clients.

* Explode entity CRUD operation trait and interface to smaller components
per operation.

* Added missing organization property to Company entity.

* Added more details about the actual behavior of the Company membership API.

* Introducing new base class and interface for developer- and company
entity.

* Refactored basic and Management API tests.

* Bump minimum version of php-http/client-common to >=1.8.1.

1.8.0 contains a regression bug:
php-http/client-common#112

* Add new required patch to php-http/client-common.

php-http/client-common#113

* Disable process timeout to prevent failing test runs caused by
PHPUnit executed via a Composer command.

* Removed useless PHP nightly builds from testing matrix.

* Added test to getDeveloperByApp.

* Introducing new base exception interface for our client.

* Introducing API client specific RuntimeException class.

* Throw more meaningful exceptions when an entity property has an
incorrect value.

* Be more type-strict by replacing array arguments on data object's
setters with type strict variable-length arguments.

* Fix implementation of getProperties(). (BC breaking change.)
@ezimuel ezimuel mentioned this issue Feb 16, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbu