Capture comments in Variable assignments #8

php-gettext · May 22, 2020 · 10e1a70 · 10e1a70
1 parent a554256
commit 10e1a70
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/PhpNodeVisitor.php b/src/PhpNodeVisitor.php
@@ -45,6 +45,7 @@ public function enterNode(Node $node)
             case 'Stmt_Echo':
             case 'Stmt_Return':
             case 'Expr_Print':
+            case 'Expr_Assign':
                 $this->bufferComments = $node;
                 return null;
         }

diff --git a/tests/PhpFunctionsScannerTest.php b/tests/PhpFunctionsScannerTest.php
@@ -164,7 +164,9 @@ public function testPhpFunctionsExtractor()
         $this->assertSame(30, $function->getLine());
         $this->assertSame(30, $function->getLastLine());
         $this->assertSame($file, $function->getFilename());
-        $this->assertCount(0, $function->getComments());
+        $this->assertCount(1, $function->getComments());
+        $comments = $function->getComments();
+        $this->assertSame('Related comment 5', array_shift($comments));
     }
 
     public function _testPhpFunctionsScannerWithDisabledComments()

diff --git a/tests/assets/functions.php b/tests/assets/functions.php
@@ -26,5 +26,5 @@
     'arg12'
     /* No Related comment 4 */
 );
-
-fn13("Translatable string","",["context"=>"Context string", 'foo']);
+//Related comment 5
+$bar = fn13("Translatable string","",["context"=>"Context string", 'foo']);