-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Way of having info modals for table rows #380
Comments
The modals that we have on the other pages are generic and meant to be triggered from any other page. If your goal is to support a modal only within a single page, then it should be much easier and I would probably apply some hardcoded logic to that. Something like |
Hmm, to do that and be able to conditionally render the modal, it would require to create a custom component to be rendered in the If thats so, it should probably work fine :) |
I am not quite sure because I haven't used the dashboard for a while. :) So feel free to give whatever comes to your mind a try :) |
Hahah got it! Thanks for the help! :) |
After working on #401, I had some ideas related to this issue. We can define a External modals can be passed as an option in the router. Another option could be a Protocol, but not sure if it is the best option here. @josevalim if you think it is worth the idea I will give it a try, or you have a better suggestion :) |
Currently some of the default pages, like ETS, Process, etc. have clickable rows that shows a modal with more detailed information. Right now, as far as I can see in the code there's no way of having this for custom pages.
There are plans for having such feature?
I was thinking that the PageBuilder could have a callback for defining some configuration for showing a modal. Maybe having 2 ways of configuring it:
I would be happy to help with an PR, but probably need to discuss the API for this, since its a big change 😄
The text was updated successfully, but these errors were encountered: