Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo's under a todolist group #2

Open
slash5k1 opened this issue Nov 3, 2018 · 2 comments
Open

todo's under a todolist group #2

slash5k1 opened this issue Nov 3, 2018 · 2 comments

Comments

@slash5k1
Copy link

slash5k1 commented Nov 3, 2018

Hi,

I started looking in to the basecamp api and came across your package and wondered if it was possible to not only get todo's at the top level of a todo list but also within a todo group? ie:

screen shot 2018-11-03 at 9 34 56 pm

@slash5k1
Copy link
Author

slash5k1 commented Nov 3, 2018

Just seen that you are yet to implement anything with your TodoListGroup class.

Making the following changes allowed me to see todos under a todo group:

  1. added list method
  2. changed inheritance of TodoListGroup to recordings.Recording; and
  3. added recordings to the import line.
from . import _base, projects, todolists, util, recordings

class TodoListGroup(recordings.Recording):

    def list(self, status=None, completed=None):
        return self._endpoint._api.todos.list(todolist=self, project=self.project_id,
                                              status=status, completed=completed)

Hope this helps someone else who finds your library 😃

BTW - you have implemented a fair amount of work in here... thankyou for uploading to GitHub to share! 👍

@slash5k1 slash5k1 closed this as completed Nov 4, 2018
@phistrom phistrom reopened this Nov 4, 2018
@phistrom
Copy link
Owner

phistrom commented Nov 4, 2018

I would like to keep this issue open until I have implemented it. I hope it is ok with you. You are also welcome to submit a pull request with your proposed changes. Thanks for your interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants