From 763cc957dec99e6db5a9ab2e8dc62fd8ac8bf451 Mon Sep 17 00:00:00 2001
From: Graham McGregor <graham@gmcgregor.ca>
Date: Sat, 15 Apr 2017 12:30:31 -0400
Subject: [PATCH] Limit number of events used to assess level

With large numbers of historical events the application starts to lag
when assessing the users level. This provides a fix that keeps
"good-enough" functionality.

Profiling found that most of the time is in creating new event objects
when we unfold them per key.

Mostly addresses #10
---
 app/scripts/services/level_service.js | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/app/scripts/services/level_service.js b/app/scripts/services/level_service.js
index 1ada1f2..a0de7cb 100644
--- a/app/scripts/services/level_service.js
+++ b/app/scripts/services/level_service.js
@@ -96,6 +96,10 @@ const LevelService = {
     //    average time of < Y s
     //    success rate > Z
 
+    // only consider the last 1500 events for performance reasons
+    // 1500 picked for 12 semitones in an octave * 100 success events / 0.8 for 80% success rate
+    let eventsToAssess = events.slice(-1500);
+
     const thresholdSettings = AppFreezer.get().settings.pitchReading.automaticDifficulty;
 
     optThresholds = optThresholds || {
@@ -103,7 +107,11 @@ const LevelService = {
       accuracy: thresholdSettings.accuracyGoal,
       time: thresholdSettings.timeGoal
     };
-    const unfoldedEvents = _.flatMap(events, (event) => {
+
+    const filteredEvents = eventsToAssess.filter((event) =>
+      event.keys.some(this.levelContainsKey.bind(this, level))
+    );
+    const unfoldedEvents = _.flatMap(filteredEvents, (event) => {
       return event.keys.map((key) => {
         const subEvent = {
           ...event,
@@ -113,19 +121,15 @@ const LevelService = {
         return subEvent;
       });
     });
-    const filteredEvents = unfoldedEvents.filter((event) =>
-      this.levelContainsKey(level, event.key)
-    );
-
-    const eventsByKey = _.groupBy(filteredEvents, "key");
+    const eventsByKey = _.groupBy(unfoldedEvents, "key");
     if (_.size(eventsByKey) < this.getNotesOfLevel(level)) {
       return false;
     }
     const evaluation = _.map(eventsByKey, (events, key) => {
-      const successPartition = _.partition(events, "success")[0];
+      const successPartition = _.partition(eventsToAssess, "success")[0];
 
-      const eventsLength = events.length;
-      const accuracy = successPartition.length / events.length;
+      const eventsLength = eventsToAssess.length;
+      const accuracy = successPartition.length / eventsToAssess.length;
       const time = _.sum(successPartition.map((el) => el.time)) / successPartition.length;
 
       const meetsLength = eventsLength >= optThresholds.amount;