Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH http result 201 should be accepted as valid #56

Open
ylebre opened this issue Dec 24, 2020 · 1 comment
Open

PATCH http result 201 should be accepted as valid #56

ylebre opened this issue Dec 24, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@ylebre
Copy link

ylebre commented Dec 24, 2020

I was trying to see if I could start a chess game using php-solid-server as a storage pod. Logging in works, but starting a new game fails because the function 'writePermission' in core.js expects a 200 OK result, whereas php-solid-server returns a '201 Created'

I would have expected any 2xx result to be accepted as 'ok' in this function.

@pheyvaer
Copy link
Owner

pheyvaer commented Jan 4, 2021

Hi @ylebre

Thanks for creating an issue! Yes, indeed 2xx should be enough.

@pheyvaer pheyvaer added the bug Something isn't working label Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants