Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gulp-sass #41

Open
B-Prod opened this issue Feb 12, 2018 · 4 comments
Open

Upgrade gulp-sass #41

B-Prod opened this issue Feb 12, 2018 · 4 comments

Comments

@B-Prod
Copy link

B-Prod commented Feb 12, 2018

Could it be possible to upgrade gulp-sass, as the used version depends on node-sass 3.4.2, a very old one?
@B-Prod
Copy link
Author

B-Prod commented Feb 12, 2018

I tried to move to:
"gulp-sass": "3.1.0"
"node-sass": "4.7.2"

And the compilation seems to work correctly.

@B-Prod
Copy link
Author

B-Prod commented Jun 5, 2018

Is this project still maintained?

@geoff-winner
Copy link
Contributor

Hey @B-Prod sorry we haven't gotten back to you.. most of the development efforts have been moved to the next evolution of P2-theme-core/Pattern-Lab-Starter.

This is found here: https://github.com/phase2/particle

@joaogarin
Copy link

Would you recommend people relying still on p2-theme-core to move away from it? its an npm dependency and currently has some security vulnerabilities. would be happy to provide some PR's for them..but would like to kind of know a status on it since you mention most of the development efforts have moved away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@B-Prod @joaogarin @geoff-winner