Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS and PHPLINT Quality Checks configuration still too broad #279

Open
grayside opened this issue May 5, 2016 · 0 comments
Open

PHPCS and PHPLINT Quality Checks configuration still too broad #279

grayside opened this issue May 5, 2016 · 0 comments

Comments

@grayside
Copy link
Contributor

grayside commented May 5, 2016

PHPCS and PHPLINT are traversing the files directory within src/sites, which for an operating site means scanning all uploaded styles, as well as any cached files. This would mostly be a performance overhead, except something toolbar related in my current D8 project has placed some broken PHP code into the files directory by way of caching.

This can be fixed by replacing:

    '<%= config.srcPaths.drupal %>/sites/**/*.{php,inc}',

with something like

   '<%= config.srcPaths.drupal %>/sites/*.{php,inc}',
   '<%= config.srcPaths.drupal %>/sites/*/*.{php,inc}',

The goal is to keep an eye out on any PHP configuration files under src/sites or an immediate subdirectory thereof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant