Merge pull request #7 from Alokzh/fix-core-implementation

Improve Stack Implementation by making it Array based & adding missing methods with proper Tests

Author: jordanmontt

.github/workflows/CI.yml

@@ -0,0 +1,32 @@
+name: CI
+
+env:
+  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+  workflow_dispatch:
+
+jobs:
+  build:
+    strategy:
+      matrix:
+        os: [macos-latest, ubuntu-latest, windows-latest]
+        smalltalk: [Pharo64-13, Pharo64-12, Pharo64-11, Pharo64-10]
+
+    runs-on: ${{ matrix.os }}
+    name: ${{ matrix.smalltalk }} on ${{ matrix.os }}
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Setup SmalltalkCI
+        uses: hpi-swa/setup-smalltalkCI@v1
+        with:
+          smalltalk-version: ${{ matrix.smalltalk }}
+      - name: Load and Test
+        run: smalltalkci -s ${{ matrix.smalltalk }}
+        shell: bash
+        timeout-minutes: 15

.github/workflows/currentStablePharo.yml

@@ -1,34 +1,27 @@
 # Containers-Stack
-A dead stupid stack implementation, but one fully working with super cool coverage:)
-
-
-![https://github.com/pharo-containers/Containers-Stack/actions](https://github.com/pharo-containers/Containers-Stack/workflows/Matrix/badge.svg)
-[![License](https://img.shields.io/badge/license-MIT-blue.svg)](https://img.shields.io/badge/license-MIT-blue.svg)
-[![Coverage Status](https://coveralls.io/repos/github/pharo-containers/Containers-Stack/badge.svg?branch=master)](https://coveralls.io/github/pharo-containers/Containers-Stack?branch=master)
-## Example
-
-``` 
-| aStack |
- aStack := CTStack new.
- aStack push: 'a'.
- aStack size >>> 1.
- aStack push: 'b'.
- aStack size >>> 2.
- aStack top >>> 'b'.
- aStack size >>> 2.
- aStack pop  >>> 'b'.
- aStack size >>> 1.
- aStack pop >>> 'a'.
- aStack size >>> 0. 
- ```
+A High-performance, Array based Stack implementation providing efficient LIFO (Last In, First Out) operations with fixed capacity and proper bounds checking.
+
+![Pharo Version](https://img.shields.io/badge/Pharo-10+-blue)
+[![License: MIT](https://img.shields.io/badge/License-MIT-green.svg)](LICENSE)
+
+## What is a Stack?
+
+A Stack is a linear data structure that follows the LIFO (Last In, First Out) principle. Elements are added and removed from the same end, called the "top" of the stack. Think of it like a stack of plates - you can only add or remove plates from the top.
+
+### Key Benefits
+- **O(1) Performance**: Constant time push, pop, and top operations
+- **Fixed Memory Usage**: Array-based implementation with bounded capacity
+- **Memory Safe**: Automatic cleanup prevents memory leaks
+- **Simple API**: Clean, intuitive interface following standard conventions
+- **Robust Error Handling**: Proper stack overflow and underflow protection
 
 ## Loading 
 The following script installs Containers-Stack in Pharo.
 
 ```smalltalk
 Metacello new
   baseline: 'ContainersStack';
-  repository: 'github://pharo-containers/Containers-Stack:v1.0/src';
+  repository: 'github://pharo-containers/Containers-Stack/src';
   load.
 ```
 
@@ -39,5 +32,33 @@ Add the following code to your Metacello baseline or configuration
 ```smalltalk
 spec 
    baseline: 'ContainersStack' 
-   with: [ spec repository: 'github://pharo-containers/Containers-Stack:v1.0/src' ].
+   with: [ spec repository: 'github://pharo-containers/Containers-Stack/src' ].
+```
+
+## Quick Start
+
+```smalltalk
+"Create a stack with capacity of 5"
+stack := CTStack new: 5.
+
+"Push elements"
+stack push: 'first'.
+stack push: 'second'.
+stack push: 'third'.
+
+"Check top element without removing"
+stack top.           "Returns 'third'"
+stack size.          "Returns 3"
+
+"Pop elements (LIFO order)"
+stack pop.           "Returns 'third'"
+stack pop.           "Returns 'second'"  
+stack pop.           "Returns 'first'"
+
+"Stack is now empty"
+stack isEmpty.       "Returns true"
 ```
+
+## Contributing
+
+This is part of the Pharo Containers project. Feel free to contribute by implementing additional methods, improving tests, or enhancing documentation.

.github/workflows/matrix.yml

@@ -1,10 +1,11 @@
 Class {
-	#name : #BaselineOfContainersStack,
-	#superclass : #BaselineOf,
-	#category : #BaselineOfContainersStack
+	#name : 'BaselineOfContainersStack',
+	#superclass : 'BaselineOf',
+	#category : 'BaselineOfContainersStack',
+	#package : 'BaselineOfContainersStack'
 }
 
-{ #category : #baseline }
+{ #category : 'baselines' }
 BaselineOfContainersStack >> baseline: spec [ 
 	<baseline>
 

README.md

@@ -1 +1 @@
-Package { #name : #BaselineOfContainersStack }
+Package { #name : 'BaselineOfContainersStack' }