Skip to content

Commit a3b6911

Browse files
committed
Improved naming
1 parent c4c8fe3 commit a3b6911

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ Register the types and distance functions
122122
```php
123123
use Pgvector\Doctrine\PgvectorSetup;
124124

125-
PgvectorSetup::register($entityManager);
125+
PgvectorSetup::registerTypes($entityManager);
126126
```
127127

128128
Enable the extension

src/doctrine/PgvectorSetup.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,30 +9,30 @@
99

1010
abstract class PgvectorSetup
1111
{
12-
public static function register(EntityManager $entityManager): void
12+
public static function registerTypes(?EntityManager $entityManager): void
1313
{
14-
self::registerTypes();
15-
self::registerPlatformTypes($entityManager->getConnection()->getDatabasePlatform());
16-
self::registerFunctions($entityManager->getConfiguration());
14+
self::addTypes();
15+
self::registerTypeMapping($entityManager->getConnection()->getDatabasePlatform());
16+
self::addFunctions($entityManager->getConfiguration());
1717
}
1818

19-
private static function registerTypes(): void
19+
private static function addTypes(): void
2020
{
2121
Type::addType('vector', 'Pgvector\Doctrine\VectorType');
2222
Type::addType('halfvec', 'Pgvector\Doctrine\HalfVectorType');
2323
Type::addType('bit', 'Pgvector\Doctrine\BitType');
2424
Type::addType('sparsevec', 'Pgvector\Doctrine\SparseVectorType');
2525
}
2626

27-
private static function registerPlatformTypes(AbstractPlatform $platform): void
27+
private static function registerTypeMapping(AbstractPlatform $platform): void
2828
{
2929
$platform->registerDoctrineTypeMapping('vector', 'vector');
3030
$platform->registerDoctrineTypeMapping('halfvec', 'halfvec');
3131
$platform->registerDoctrineTypeMapping('bit', 'bit');
3232
$platform->registerDoctrineTypeMapping('sparsevec', 'sparsevec');
3333
}
3434

35-
private static function registerFunctions(Configuration $config): void
35+
private static function addFunctions(Configuration $config): void
3636
{
3737
$config->addCustomNumericFunction('l2_distance', 'Pgvector\Doctrine\L2Distance');
3838
$config->addCustomNumericFunction('max_inner_product', 'Pgvector\Doctrine\MaxInnerProduct');

tests/DoctrineTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public static function setUpBeforeClass(): void
3434

3535
$entityManager = new EntityManager($connection, $config);
3636
$entityManager->getConnection()->executeStatement('CREATE EXTENSION IF NOT EXISTS vector');
37-
PgvectorSetup::register($entityManager);
37+
PgvectorSetup::registerTypes($entityManager);
3838

3939
$schemaManager = $entityManager->getConnection()->createSchemaManager();
4040
try {

0 commit comments

Comments
 (0)