Renamed as_vector function to values

Author: ankane

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 - Added support for libpqxx 8
 - Changed `HalfVector` to use `std::float16_t` or `_Float16` when available
-- Replaced `std::vector` conversion with `as_vector` function for `Vector` and `HalfVector`
+- Replaced `std::vector` conversion with `values` function for `Vector` and `HalfVector`
 - Removed default constructors (no longer needed for streaming)
 - Dropped support for libpqxx 7
 - Dropped support for C++17

include/pgvector/halfvec.hpp

@@ -46,8 +46,8 @@ class HalfVector {
         return value_.size();
     }
 
-    /// Returns the half vector as a `std::vector`.
-    const std::vector<Half>& as_vector() const {
+    /// Returns the values.
+    const std::vector<Half>& values() const {
         return value_;
     }
 

include/pgvector/pqxx.hpp

@@ -47,7 +47,7 @@ template<> struct string_traits<pgvector::Vector> {
     }
 
     static std::string_view to_buf(std::span<char> buf, const pgvector::Vector& value, ctx c = {}) {
-        const std::vector<float>& values = value.as_vector();
+        const std::vector<float>& values = value.values();
 
         // important! size_buffer cannot throw an exception on overflow
         // so perform this check before writing any data
@@ -71,7 +71,7 @@ template<> struct string_traits<pgvector::Vector> {
     }
 
     static size_t size_buffer(const pgvector::Vector& value) noexcept {
-        const std::vector<float>& values = value.as_vector();
+        const std::vector<float>& values = value.values();
 
         // cannot throw an exception here on overflow
         // so throw in into_buf
@@ -113,7 +113,7 @@ template<> struct string_traits<pgvector::HalfVector> {
     }
 
     static std::string_view to_buf(std::span<char> buf, const pgvector::HalfVector& value, ctx c = {}) {
-        const std::vector<pgvector::Half>& values = value.as_vector();
+        const std::vector<pgvector::Half>& values = value.values();
 
         // important! size_buffer cannot throw an exception on overflow
         // so perform this check before writing any data
@@ -137,7 +137,7 @@ template<> struct string_traits<pgvector::HalfVector> {
     }
 
     static size_t size_buffer(const pgvector::HalfVector& value) noexcept {
-        const std::vector<pgvector::Half>& values = value.as_vector();
+        const std::vector<pgvector::Half>& values = value.values();
 
         // cannot throw an exception here on overflow
         // so throw in into_buf

include/pgvector/vector.hpp

@@ -30,8 +30,8 @@ class Vector {
         return value_.size();
     }
 
-    /// Returns the vector as a `std::vector`.
-    const std::vector<float>& as_vector() const {
+    /// Returns the values.
+    const std::vector<float>& values() const {
         return value_;
     }
 

test/halfvec_test.cpp

@@ -16,13 +16,13 @@ static void test_constructor_span() {
     assert_equal(vec.dimensions(), 3u);
 }
 
-static void test_as_vector() {
+static void test_values() {
     HalfVector vec{{1, 2, 3}};
-    assert_equal(vec.as_vector() == std::vector<pgvector::Half>{1, 2, 3}, true);
+    assert_equal(vec.values() == std::vector<pgvector::Half>{1, 2, 3}, true);
 }
 
 void test_halfvec() {
     test_constructor_vector();
     test_constructor_span();
-    test_as_vector();
+    test_values();
 }

test/vector_test.cpp

@@ -16,13 +16,13 @@ static void test_constructor_span() {
     assert_equal(vec.dimensions(), 3u);
 }
 
-static void test_as_vector() {
+static void test_values() {
     Vector vec{{1, 2, 3}};
-    assert_equal(vec.as_vector() == std::vector<float>{1, 2, 3}, true);
+    assert_equal(vec.values() == std::vector<float>{1, 2, 3}, true);
 }
 
 void test_vector() {
     test_constructor_vector();
     test_constructor_span();
-    test_as_vector();
+    test_values();
 }