Switched to move contructor

ankane · ankane · commit c14123ca84eb · 2026-02-28T12:31:55.000-08:00
diff --git a/include/pgvector/pqxx.hpp b/include/pgvector/pqxx.hpp
@@ -41,7 +41,7 @@ template <> struct string_traits<pgvector::Vector> {
                 result.push_back(string_traits<float>::from_string(substr, c));
             }
         }
-        return pgvector::Vector(result);
+        return pgvector::Vector(std::move(result));
     }
 
     static std::string_view to_buf(std::span<char> buf, const pgvector::Vector& value, ctx c = {}) {
@@ -78,7 +78,7 @@ template <> struct string_traits<pgvector::HalfVector> {
                 result.push_back(string_traits<float>::from_string(substr, c));
             }
         }
-        return pgvector::HalfVector(result);
+        return pgvector::HalfVector(std::move(result));
     }
 
     static std::string_view to_buf(std::span<char> buf, const pgvector::HalfVector& value, ctx c = {}) {

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ template <> struct string_traits<pgvector::Vector> {`
`41`	`41`	`result.push_back(string_traits<float>::from_string(substr, c));`
`42`	`42`	`}`
`43`	`43`	`}`
`44`		`- return pgvector::Vector(result);`
	`44`	`+ return pgvector::Vector(std::move(result));`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`static std::string_view to_buf(std::span<char> buf, const pgvector::Vector& value, ctx c = {}) {`
`@@ -78,7 +78,7 @@ template <> struct string_traits<pgvector::HalfVector> {`
`78`	`78`	`result.push_back(string_traits<float>::from_string(substr, c));`
`79`	`79`	`}`
`80`	`80`	`}`
`81`		`- return pgvector::HalfVector(result);`
	`81`	`+ return pgvector::HalfVector(std::move(result));`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`static std::string_view to_buf(std::span<char> buf, const pgvector::HalfVector& value, ctx c = {}) {`