Removed assert_true function

Author: ankane

test/helper.hpp

@@ -16,10 +16,6 @@ void assert_equal(const T& left, const U& right, const std::source_location& loc
     }
 }
 
-inline void assert_true(bool condition, const std::source_location& loc = std::source_location::current()) {
-    assert_equal(condition, true, loc);
-}
-
 template<typename T>
 void assert_exception(std::function<void(void)> code, std::optional<std::string_view> message = std::nullopt) {
     bool exception = false;
@@ -31,5 +27,5 @@ void assert_exception(std::function<void(void)> code, std::optional<std::string_
             assert_equal(std::string_view(e.what()), *message);
         }
     }
-    assert_true(exception);
+    assert_equal(exception, true);
 }

test/pqxx_test.cpp

@@ -41,7 +41,7 @@ void test_vector(pqxx::connection &conn) {
     assert_equal(res.size(), 3);
     assert_equal(res[0][0].as<pgvector::Vector>(), embedding2);
     assert_equal(res[1][0].as<pgvector::Vector>(), embedding);
-    assert_true(!res[2][0].as<std::optional<pgvector::Vector>>().has_value());
+    assert_equal(res[2][0].as<std::optional<pgvector::Vector>>().has_value(), false);
 }
 
 void test_halfvec(pqxx::connection &conn) {
@@ -57,7 +57,7 @@ void test_halfvec(pqxx::connection &conn) {
     assert_equal(res.size(), 3);
     assert_equal(res[0][0].as<pgvector::HalfVector>(), embedding2);
     assert_equal(res[1][0].as<pgvector::HalfVector>(), embedding);
-    assert_true(!res[2][0].as<std::optional<pgvector::HalfVector>>().has_value());
+    assert_equal(res[2][0].as<std::optional<pgvector::HalfVector>>().has_value(), false);
 }
 
 void test_bit(pqxx::connection &conn) {
@@ -72,7 +72,7 @@ void test_bit(pqxx::connection &conn) {
     assert_equal(res.size(), 3);
     assert_equal(res[0][0].as<std::string>(), embedding2);
     assert_equal(res[1][0].as<std::string>(), embedding);
-    assert_true(!res[2][0].as<std::optional<std::string>>().has_value());
+    assert_equal(res[2][0].as<std::optional<std::string>>().has_value(), false);
 }
 
 void test_sparsevec(pqxx::connection &conn) {
@@ -87,7 +87,7 @@ void test_sparsevec(pqxx::connection &conn) {
     assert_equal(res.size(), 3);
     assert_equal(res[0][0].as<pgvector::SparseVector>(), embedding2);
     assert_equal(res[1][0].as<pgvector::SparseVector>(), embedding);
-    assert_true(!res[2][0].as<std::optional<pgvector::SparseVector>>().has_value());
+    assert_equal(res[2][0].as<std::optional<pgvector::SparseVector>>().has_value(), false);
 }
 
 void test_sparsevec_nnz(pqxx::connection &conn) {

test/sparsevec_test.cpp

@@ -10,8 +10,8 @@ using pgvector::SparseVector;
 static void test_constructor_vector() {
     auto vec = SparseVector({1, 0, 2, 0, 3, 0});
     assert_equal(vec.dimensions(), 6);
-    assert_true(vec.indices() == (std::vector<int>{0, 2, 4}));
-    assert_true(vec.values() == (std::vector<float>{1, 2, 3}));
+    assert_equal(vec.indices() == (std::vector<int>{0, 2, 4}), true);
+    assert_equal(vec.values() == (std::vector<float>{1, 2, 3}), true);
 }
 
 static void test_constructor_span() {
@@ -23,8 +23,8 @@ static void test_constructor_map() {
     std::unordered_map<int, float> map = {{2, 2}, {4, 3}, {3, 0}, {0, 1}};
     auto vec = SparseVector(map, 6);
     assert_equal(vec.dimensions(), 6);
-    assert_true(vec.indices() == (std::vector<int>{0, 2, 4}));
-    assert_true(vec.values() == (std::vector<float>{1, 2, 3}));
+    assert_equal(vec.indices() == (std::vector<int>{0, 2, 4}), true);
+    assert_equal(vec.values() == (std::vector<float>{1, 2, 3}), true);
 
     assert_exception<std::invalid_argument>([&]{
         auto unused = SparseVector(map, 0);