Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for cargo-binstall #1958

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

usamoi
Copy link
Contributor

@usamoi usamoi commented Dec 9, 2024

#681

The support could be added to all 0.12.* versions.

See https://github.com/usamoi/pgrx/releases/tag/v0.12.7 for downloading binaries generated by this pull request.

@eeeebbbbrrrr
Copy link
Contributor

I'm very confused about what this PR is meant to do. It adds a new GH workflow file, modifies some tests and (seemingly) reformats unbox.rs?

@usamoi
Copy link
Contributor Author

usamoi commented Dec 31, 2024

I'm very confused about what this PR is meant to do. It adds a new GH workflow file, modifies some tests and (seemingly) reformats unbox.rs?

When this PR was submitted, without modifying tests and formatting unbox.rs, CI cannot pass.

It adds a new GH workflow file to build binaries for cargo-pgrx so that cargo-binstall could discover them.

Edit: removed now

@eeeebbbbrrrr
Copy link
Contributor

The new workflow attaches binaries to our tagged releases, right?

#681 was kinda left in a bit of a nebulous state. @workingjubilee do we want to do this? I can only see this being useful if the consumer doesn't intend to upgrade cargo-pgrx very often.

The "resource constrained machines" bit over in #681 is compelling, I suppose, but it also takes some serious resources to use cargo-pgrx in any meaningful way, so... still not sure of the value.

There's little cost on our end, so I won't block this if you think it's a good idea.

@usamoi
Copy link
Contributor Author

usamoi commented Dec 31, 2024

I want to install cargo-pgrx without building it in CI, and it's why I prefer cargo binstall...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants