Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: cargo pgrx init/make world-bin enable parallel build #1903

Open
SteveLauC opened this issue Oct 8, 2024 · 0 comments
Open

Comments

@SteveLauC
Copy link
Contributor

SteveLauC commented Oct 8, 2024

Hi, I just initialized this tool on one of my Linux machines, cargo pgrx init --pg17 download takes roughly 3 minutes, looking at the source code:

let mut command = std::process::Command::new("make");
command
.arg("world-bin")
.stdout(std::process::Stdio::piped())
.stderr(std::process::Stdio::piped())
.stdin(std::process::Stdio::null())
.current_dir(pgdir);
for var in PROCESS_ENV_DENYLIST {
command.env_remove(var);
}
let command_str = format!("{command:?}");
tracing::debug!(command = %command_str, "Running");
let child = init.jobserver.get().unwrap().configure_and_run(&mut command, |cmd| cmd.spawn())?;
let output = child.wait_with_output()?;
tracing::trace!(status_code = %output.status, command = %command_str, "Finished");
if output.status.success() {
Ok(())
} else {
Err(eyre!(
"{}\n{}{}",
command_str,
String::from_utf8(output.stdout)?,
String::from_utf8(output.stderr)?
))
}

We are not building Postgres in parallel, any reason behind this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant