Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent note duration #36

Open
pganssle opened this issue Nov 28, 2023 · 0 comments
Open

Use consistent note duration #36

pganssle opened this issue Nov 28, 2023 · 0 comments

Comments

@pganssle
Copy link
Owner

When I originally put this app together, I used a bunch of varying durations, because I didn't want the kids to end up learning the sound of a specific file and duration instead of learning the note. However, according to the book, you should actually aim for consistency with the notes (from a translation):

Play the chords for about two seconds. Count slowly, "one, two," and cut off the sound on "three." Always maintain the same duration for each chord. It is not advisable to play staccato one day and then play elongated notes the next day.

In the Tone.js version this is pretty easy to accomplish, because the duration is set programmatically, but it might be more annoying to backport that to the "legacy" version. If we can reliably fix #24, I'd be more comfortable with abandoning the old pre-recorded sounds.

On the plus side, it's a lot easier to provide pre-recorded files for every chord (as opposed to using Tone.js) if they are always the same length, since you just need 1 file per chord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant